This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Implement logic for TriggerRules config #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 84.61% 85.48% +0.86%
==========================================
Files 5 9 +4
Lines 247 427 +180
==========================================
+ Hits 209 365 +156
- Misses 34 58 +24
Partials 4 4
|
nacx
previously approved these changes
Feb 12, 2024
internal/server/authz.go
Outdated
| // If there are no trigger rules, allow the request with no check executions. | ||
| // TriggerRules are used to determine which request should be checked by the filter and which don't. | ||
| if !mustTriggerCheck(e.cfg.TriggerRules, req) { | ||
| e.log.Debug(fmt.Sprintf("no matching trigger rule, so allowing request to proceed without any authservice functionality %s://%s%s", |
There was a problem hiding this comment.
Let's get the log.Context(ctx) to make sure we include any context logs here (such as the x-requesd-id or others that we could populate)
internal/server/authz.go
Outdated
| return strings.HasSuffix(path, m.Suffix) | ||
| case *configv1.StringMatch_Regex: | ||
| b, _ := regexp.MatchString(m.Regex, path) | ||
| // TODO: handle error |
There was a problem hiding this comment.
Let's just log the error and return false?
| {"suffix-match", stringSuffix("test"), "123-test", true}, | ||
| {"suffix-no-match", stringSuffix("test"), "no-match", false}, | ||
| {"regex-match", stringRegex(".*st"), "test", true}, | ||
| {"regex-no-match", stringRegex(".*st"), "no-match", false}, |
There was a problem hiding this comment.
Add a test for the regexp error as well.
nacx
reviewed
Feb 12, 2024
internal/server/authz.go
Outdated
| @@ -72,6 +73,17 @@ func (e *ExtAuthZFilter) Register(server *grpc.Server) { | |||
|
|
|||
| // Check is the implementation of the Envoy AuthorizationServer interface. | |||
| func (e *ExtAuthZFilter) Check(ctx context.Context, req *envoy.CheckRequest) (response *envoy.CheckResponse, err error) { | |||
| // If there are no trigger rules, allow the request with no check executions. | |||
| // TriggerRules are used to determine which request should be checked by the filter and which don't. | |||
| trLog := e.log.Context(ctx) | |||
There was a problem hiding this comment.
In line 90 we're already getting the log from the context. let's just create the log variable here and reuse it later?
There was a problem hiding this comment.
totally, didn't notice that.
nacx
approved these changes
Feb 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.