Enhance normalize uri #14
Conversation
| uri = "git://" + uri.substring(4); | ||
| } | ||
| //2. Replace github.com: with github.com/ | ||
| String githubDotCom = "github.com"; |
There was a problem hiding this comment.
The host might be arbitrary, like bitbucket.org: https://bitbucket.org/cofarrell/bower-maven-plugin/src/ee0f41a83905?at=master
scabanovich
force-pushed
the
normalize-uri
branch
from
72dbf59 to
ca1c995
Compare
| // into | ||
| // git://github.com/errai/errai.git | ||
| // These 3 distinctions may happen independently in other cases. | ||
| String gitPrefix = "git://"; |
There was a problem hiding this comment.
It looks like git@ is actually an ssh:// url which, in github's case, only requires you to have a private key that matches with a ssh public key signature in github settings.
There was a problem hiding this comment.
Ok, let's first attempt connection with SSH, and if it fails, show message that suggests user connecting git anonymously. If user cancels, just do nothing, if user confirms, change URL from git@ into git:// and repeat the attempt.
scabanovich
force-pushed
the
normalize-uri
branch
from
ca1c995 to
f108279
Compare
|
@scabanovich can you please add some unit tests? |
scabanovich
force-pushed
the
normalize-uri
branch
from
f108279 to
52915f9
Compare
|
Tests are added. |
| final boolean[] result = new boolean[]{false}; | ||
| Display.getDefault().syncExec(new Runnable() { | ||
| @Override | ||
| public void run() { |
There was a problem hiding this comment.
The method run() of type new Runnable(){} must override a superclass method.
This error shows up because the project BREE is J2SE-1.5 and I happen to have a Java 5 JDK, exhibiting the issue.
We should bump the BREE to 1.7, as well as the project version to 0.15.0-SNAPSHOT
|
Other than the BREE issue and the text to tweak, everything seems to work as advertised |
scabanovich
force-pushed
the
normalize-uri
branch
from
52915f9 to
befb115
Compare
| throw new CoreException(new Status(IStatus.ERROR, getClass().getName(), cause.getMessage(), cause)); | ||
| } catch(IOException e) { | ||
| throw new CoreException(new Status(IStatus.ERROR, getClass().getName(), e.getMessage(), e)); | ||
| } catch(URISyntaxException e) { |
scabanovich
force-pushed
the
normalize-uri
branch
from
befb115 to
d5ab2d8
Compare
1) remove tail after .git 2) In case SSH protocol is used and failed, suggest connecting git anonymously. If user cancels, do nothing, just cancel the operation. If user confirms, a) set git:// instead git@ b) set host/ instead host: Steps to reproduce: 1. Clone https://github.com/jenkinsci/jenkins 2. Import into Eclipse as a maven project. 3. Select in cli project in Maven Dependencies javassist-3.19.0.GA.jar and call Maven-> Import project(s) from SCM. 'Select Maven artifacts' press Next, then Finish. 4. If you have ssh key: Expected result: repository will be cloned, and 'Select Maven Projects' page will appear with projects to import. Current failure: 'Select Maven Projects' page appears empty. Fixed by (1 - remove tail after .git) 5. If you do not have ssh key: Expected result: a dialog 'Auth fail' appears that suggests connecting git anonymously. If accepted, continues as in 4. Current failure: 'Select Maven Projects' page appears empty. After fix of (1) - failure - system error dialog reporting exception 'Auth failed'. Fixed by (1) and (2).
scabanovich
force-pushed
the
normalize-uri
branch
from
d5ab2d8 to
4262766
Compare
Changes:
remove tail after .git
In case SSH protocol is used and failed, suggest connecting git anonymously.
If user cancels, do nothing, just cancel the operation.
If user confirms,
a) set git:// instead git@
b) set host/ instead host:
Steps to reproduce:
Expected result: repository will be cloned, and 'Select Maven Projects' page will appear with projects to import.
Current failure: 'Select Maven Projects' page appears empty.
Fixed by (1 - remove tail after .git)
Expected result: a dialog 'Auth fail' appears that suggests connecting git anonymously. If accepted, continues as in 4.
Current failure: 'Select Maven Projects' page appears empty.
After fix of (1) - failure - system error dialog reporting exception 'Auth failed'.
Fixed by (1) and (2).