-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(launch
): default chain account balances
#936
Conversation
I regenerated the |
Codecov Report
@@ Coverage Diff @@
## develop #936 +/- ##
===========================================
+ Coverage 10.75% 10.77% +0.02%
===========================================
Files 280 280
Lines 66957 67091 +134
===========================================
+ Hits 7199 7227 +28
- Misses 59595 59702 +107
+ Partials 163 162 -1
|
What's your reasoning to consider it should be named To me, it's a balance imposed by the coordinator. Default would mean this is the value set if the account doesn't provide a specific amount. But it can be argued as well we can name it to "default" because this the balance that will be defined by default or accounts at first before the chain is launched and coins are moving |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Yeah, I agree default doesn't make as much sense as I originally thought. I'm going to change it back to |
Closes #927
What does this PR do?
Adds the
DefaultAccountBalance
field toChain
andMsgCreateChain
. If this field is empty (sdk.NewCoins()
). the behavior is unchanged. However, if it is populated, the balances of accounts that are created duringkeeper.ApplyRequest()
are set tochain.DefaultAccountBalance
.How to test?