Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research: What caused our dependency update issue? #1211

Open
DerekCaelin opened this issue Jan 8, 2025 · 4 comments · May be fixed by techmatters/terraso-mobile-client#2831
Open

Research: What caused our dependency update issue? #1211

DerekCaelin opened this issue Jan 8, 2025 · 4 comments · May be fixed by techmatters/terraso-mobile-client#2831
Assignees

Comments

@DerekCaelin
Copy link
Collaborator

Task to look into what the dependency update + main broken issue was (post-mortem?)

Slack: Ruxandra flags

@shrouxm
Copy link
Member

shrouxm commented Jan 8, 2025

as far as i can tell:

  • the dependency update commits started failing because of a faulty iOS build cache (all the PRs with an iOS build failure share the same build cache key)
  • the commit from ruxandra's PR failed due to a transient network error while downloading dependencies from npm
  • i don't see a super strong pattern pointing to a dominant root cause for failed workflow runs on main. it's a bit hard to check though because logs are only stored for so long
  • having better notifications & follow-ups when the main branch is broken seems like the best next step given that there isn't a single thing we can fix that would clearly make things way more reliable
  • however:
    • i do know that i & others have encountered numerous CI issues due to the iOS build cache
    • i also see that this cache is not addressing the main bottleneck of the workflow. workflow runs with a cache miss seem to take ~19mins, and workflow runs with a cache hit take ~16 mins
    • to me, there's not much of a meaningful productivity difference between 16 and 19mins. in both cases, if i'm blocked on the workflow completing i will be context switching and coming back to it later anyway
    • i therefore suggest disabling the iOS build cache

@shrouxm
Copy link
Member

shrouxm commented Jan 8, 2025

waiting for reactions to suggestion of disabling iOS build cache before closing, that should be trivial work so i'll roll it into this issue if we decide to do it

@shrouxm shrouxm moved this from Todo to In Progress in LandPKS Jan 8, 2025
@shrouxm shrouxm moved this from In Progress to Blocked/Waiting in LandPKS Jan 8, 2025
@DerekCaelin
Copy link
Collaborator Author

I didn't see these findings shared in slack; flagging here so that @paulschreiber @knipec and @tm-ruxandra can respond to Garo's suggestion:

i therefore suggest disabling the iOS build cache

@knipec
Copy link

knipec commented Jan 9, 2025

I don't have a ton of background on these issues, so would be happy to sync with Paul and garo to make sure I'm up to speed, but just from garo's description that sounds good to me

@shrouxm shrouxm moved this from Blocked/Waiting to In Review in LandPKS Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

3 participants