Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable ios build cache #2831

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

shrouxm
Copy link
Member

@shrouxm shrouxm commented Jan 16, 2025

Description

Disables the iOS build cache, per/pending discussion in techmatters/terraso-product#1211

Checklist

  • Corresponding issue has been opened

Related Issues

Closes techmatters/terraso-product#1211

with:
path: |
dev-client/ios
dev-client/node_modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: you only want to remove dev-client/ios. We need to keep node_modules cached -- prebuild makes changes to node_modules we need to preserve.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain further? the build on this PR succeeded, and i'm not understanding why an npm ci followed by npm run prebuild would need anything to be in cache for a successful build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suggesting we cache the results of npm run prebuild to save us time. this is separate from caching the iOS build step.

note there's another iOS build step you may want to disable: the ccache step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah good point, i disabled the ccache as well. i'm suggesting we not cache the results of npm run prebuild because it doesn't save enough time to justify the not infrequent build issues we experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research: What caused our dependency update issue?
2 participants