feat: privacy sheet updates #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tm-ruxandra
commented
Jun 24, 2024
knipec
reviewed
Jun 24, 2024
dev-client/src/components/sheets/privacy/DataPrivacyInfoSheet.tsx
Outdated
Show resolved
Hide resolved
knipec
reviewed
Jun 24, 2024
dev-client/src/screens/CreateProjectScreen/components/CreateProjectForm.tsx
Outdated
Show resolved
Hide resolved
knipec
approved these changes
Jun 24, 2024
|
Yes, I think we should refer to the Tech Matters Privacy Policy for now,
and we’re working to update it ASAP.
Thanks,
Steve
|
…sheet; fix incorrect heading values in components
tm-ruxandra
force-pushed
the
feat/privacy-sheet-updates
branch
from
bfe5bb8 to
7996c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace old ad-hoc privacy info modal implementation with one built on the standard
OverlaySheetcomponent. Update sheet content to match specification in design documents. Do minor cleanup in related areas.Checklist
Related Issues
#755
Verification steps
Press the info button in the following areas and verify that the sheet works as expected: