-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jac/more mypy checks #287
Open
jacalata
wants to merge
8
commits into
development
Choose a base branch
from
jac/more-mypy-checks
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jac/more mypy checks #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacalata
force-pushed
the
jac/more-mypy-checks
branch
from
January 10, 2025 22:55
e6a3aea
to
ac54b13
Compare
also add unit test
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace) * clarified help content for extract-encryption and some other not-implemented options * added tests for all valid publish command options * error log cleanup: better stacktrace, less repetition Jac/parse publish options (#236) * implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace) * clarified help content for extract-encryption and some other not-implemented options * added tests for all valid publish command options * error log cleanup: better stacktrace, less repetition Jac/parse publish options (#236) * implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group) * Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace) * clarified help content for extract-encryption and some other not-implemented options * added tests for all valid publish command options * error log cleanup: better stacktrace, less repetition
Also change a print statement to log statement
jacalata
force-pushed
the
jac/more-mypy-checks
branch
from
January 10, 2025 22:59
ac54b13
to
6021d85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabled 'check_untyped_defs' so that methods without explicit type identifiers are still checked by mypy.
Found a number of places that this didn't work, so created comments to make an exception where needed.
Some minor refactoring needed to get types or null cases recognized, and run_command method was changed from static to class method.