Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jac/more mypy checks #287

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Jac/more mypy checks #287

wants to merge 8 commits into from

Conversation

jacalata
Copy link
Contributor

@jacalata jacalata commented May 6, 2024

enabled 'check_untyped_defs' so that methods without explicit type identifiers are still checked by mypy.
Found a number of places that this didn't work, so created comments to make an exception where needed.

Some minor refactoring needed to get types or null cases recognized, and run_command method was changed from static to class method.

@jacalata jacalata added the enhancement code quality/infrastructure update label May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py101010 0%
   tabcmd.py151515 0%
   version.py633 50%
tabcmd/commands
   commands.py101010 0%
   constants.py771515 81%
   server.py1302020 85%
tabcmd/commands/auth
   session.py3664545 88%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1402020 86%
   datasources_workbooks_views_url_parser.py1401010 93%
   delete_command.py601616 73%
   export_command.py1132525 78%
   get_url_command.py1274747 63%
   publish_command.py902525 72%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py491313 73%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2822 93%
   edit_site_command.py3822 95%
   list_command.py441010 77%
   list_sites_command.py2922 93%
tabcmd/commands/user
   create_site_users.py571010 82%
   create_users_command.py601010 83%
   delete_site_users_command.py4355 88%
   user_data.py2213131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py1462323 84%
   localize.py691111 84%
   logger_config.py4266 86%
   tabcmd_controller.py4277 83%
TOTAL273445283% 

@jacalata jacalata force-pushed the jac/more-mypy-checks branch from e6a3aea to ac54b13 Compare January 10, 2025 22:55
jacalata and others added 8 commits January 10, 2025 14:58
(cherry picked from commit ef93fff)

enable type checking everywhere

(cherry picked from commit ef93fff)
* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition

Jac/parse publish options (#236)

* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition

Jac/parse publish options (#236)

* implement thumbnail options. (including 'not yet implemented' message for --thumbnail-group)
* Implement overwrite/append/replace arguments (including not-yet-implemented message for --replace)
* clarified help content for extract-encryption and some other not-implemented options
* added tests for all valid publish command options
* error log cleanup: better stacktrace, less repetition
Also change a print statement to log statement
@jacalata jacalata force-pushed the jac/more-mypy-checks branch from ac54b13 to 6021d85 Compare January 10, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code quality/infrastructure update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant