Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We (
global-devops
team) would like to enhance our logging strategy in all our lambda functions. To achieve that, we would like to add logging instructions with different logging levels and control them via an environment variable. We noticed that the package supports the latter requirement. However, with regard to logging levels, we realized that it doesn't supportDEBUG
. While working on the required changes to provide such feature, we realized that the logic to check if the data should be logged inCommonLogger.log()
was incorrect. Basically, the**kwargs
were not being propagated toCommonLogger.__should_log()
method. Thus,CommonLogger.__get_log_level()
method was returning an incorrect value.That said, this PR provides a set of changes to:
DEBUG
log levelCommonLogger
should log the given data.Signed-off-by: Isaias Ramirez Lopez [email protected]