Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add previously available types to the __all__. #1635

Closed
wants to merge 1 commit into from
Closed

Add previously available types to the __all__. #1635

wants to merge 1 commit into from

Conversation

svix-mman
Copy link
Contributor

these types were available to import before splitting the code into separate modules, so now they have to be re-exported

@svix-mman svix-mman requested a review from a team as a code owner January 14, 2025 17:33
@svix-james
Copy link
Contributor

Can we correct the spelling in the commit title?

@svix-mman svix-mman changed the title Add pervuisly avliable types to the __all__. Add previously available types to the __all__. Jan 14, 2025
@svix-mman
Copy link
Contributor Author

Can we correct the spelling in the commit title?

whops, sorry

@svix-mman
Copy link
Contributor Author

This is duplicated work, #1640 accomplishes this

@svix-mman svix-mman closed this Jan 15, 2025
@svix-jplatte
Copy link
Member

svix-jplatte commented Jan 15, 2025 •
edited
Loading

For the record, I think we should still add stuff to __all__, but we can do that as part of generating the entire api/__init__.py file properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svix-mman @svix-james @svix-jplatte