Redis dlq support #1478
Merged
Redis dlq support #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
force-pushed
the
redis-dlq-support
branch
2 times, most recently
from
8adfc31 to
8ae8326
Compare
jaymell
force-pushed
the
redis-dlq-support
branch
from
bc06ac8 to
d82b4c6
Compare
svix-gabriel
previously approved these changes
Oct 7, 2024
Yeah we probably need it. Elsewhere we monitor the queue depth, so at a minimum I should probably just add that for now. Otherwise it's completely opaque what's going on w/ the queue since we create/manage it internally. |
jaymell
force-pushed
the
redis-dlq-support
branch
3 times, most recently
from
a2a0b68 to
be6e7c2
Compare
This matches downstream changes and should make the integration of DLQ support seamless.
Add support for moving failed messages to deadletter queue in Redis. The queue can be re-driven via an undocumented endpoint, `/api/v1/admin/redrive-dlq`.
jaymell
force-pushed
the
redis-dlq-support
branch
from
be6e7c2 to
75f243a
Compare
Bring in downstream changes to prevent flakes here.
|
For now, I've added metrics to monitor the DLQ (and other queues) via metrics (#1479). We can consider adding additional admin endpoints later, but for now the metrics will prevent DLQ contents from being completely opaque to the user. |
svix-gabriel
approved these changes
Oct 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for moving failed messages to deadletter queue in
Redis. The queue can be re-driven via an undocumented endpoint,
/api/v1/admin/redrive-dlq.