Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configurable User-Agent Header #1113

Closed
wants to merge 1 commit into from
Closed

Allow configurable User-Agent Header #1113

wants to merge 1 commit into from

Conversation

igavriil
Copy link

@igavriil igavriil commented Nov 1, 2023

Motivation

The User-Agent header in HTTP webhooks serves a pivotal role in identifying
the source of the request.
For any platform sending out webhooks, it's crucial for the recipients to
recognize and authenticate the origin of the requests they are processing.

Solution

Add optional user_agent_header in server configuration

@tasn
Copy link
Member

tasn commented Nov 3, 2023

Hey @igavriil, I'd love to hear more about your exact use-case. Where are you using Svix where this has been needed?

@igavriil
Copy link
Author

igavriil commented Nov 4, 2023

When someone receives a webhook from a service they expect all the headers to be somehow related to this service. User-Agent falls in this category and having this header set to svix can create trust issues. This is not a specific usecase but more a general trust issue

@tasn
Copy link
Member

tasn commented Nov 4, 2023

@igavriil, thanks for sharing more context. I don't think it creates trust issues, nginx, caddy, and every web server send their info from the server header. The same goes with other types of software, such as: web clients, web libraries, email clients, servers, libraries, and more. This is useful information for debugging (getting the software name and version), and also a tiny shoutout to the Svix open source project which is powering the webhooks. So I think that unless we see a clear reason driven by a real use-case, rather than a hypothetical one, this is probably not something we would like to add. I'm happy to be convinced otherwise, but we generally only make changes if they are driven by real needs, and this doesn't seem to be the case here.

@igavriil igavriil closed this Nov 5, 2023
@igavriil igavriil deleted the feature/configurable-user-agent branch November 5, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants