Add initial support for displaying active BorrowDirect requests in requests tab #289
Conversation
|
FWIW, I don't believe test users can have BorrowDirect requests (and they don't have a real test system that we can use), so we kind of have to use library IDs in order to test this. I would be happy to help anybody review w/ some library IDs (or @saseestone can too) |
|
|
||
| def requests | ||
| request_client.requests('open', true).map { |request| BorrowDirectRequests::Request.new(request) }.select(&:active?) | ||
| rescue BorrowDirect::Error |
There was a problem hiding this comment.
Should we report these errors to honeybadger, or are they just expected?
There was a problem hiding this comment.
Unfortunately expected. They return an error when the user has no requests (PUBQR004: No result for query) and always in any non-production mode since their default server always returns an error (PUBSC003: Invalid parameter - Invalid PartnershipId), which I presume is because they never added us to their test system.
The BorrowDirect gem doesn't make any distinction between these and returns the top level BorrowDirect::Error. The gem does have some facility for setting expected error codes (although does not include this case), but the RequestQuery class has some assumptions about what is returned from the API and doesn't handle this case well. I would be happy to submit a PR upstream to address that, which would allow us to report the real exceptions (if folks thought that it would be worth doing)
| @@ -151,6 +151,16 @@ def to_partial_path | |||
|
|
|||
| private | |||
|
|
|||
| def borrow_direct_requests | |||
| return [] if proxy_borrower? # Proxies can't submit borrow direct requests, so don't check. | |||
There was a problem hiding this comment.
Just confirming that fee borrowers can do BD?
There was a problem hiding this comment.
I would guess probably not. @saseestone, can you confirm?
jkeck
changed the title
Closes #212
Mobile
Desktop