Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proposer): Split REQ into PROVING & WITNESSGEN #148

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Oct 9, 2024

  • Splits the REQ proof type into PROVING and WITNESSGEN. When a proof is in WITNESSGEN, it will be timed out after 20 minutes, with or without proposer restarts.
    • If you shut down the proposer and reboot it with the same DB, the WITNESSGEN proof will time out.
  • Remove the off by 1 logic from the startBlock for simplicity. Now the ranges will overlap by 1 block. This makes sense, because the proofs need to be connected.
  • Add documentation for ent generation.
  • When determining the first unrequested proof, look for the unrequested proof with the earliest start block. This will prevent potential gaps in the proposer that will increase on-chain latency.
  • Simplify some functions to use ProofRequest type directly.

@ratankaliani ratankaliani merged commit 98d0d2d into main Oct 9, 2024
7 checks passed
@ratankaliani ratankaliani deleted the ratan/fix-proofrequest-types-fix-span-proof-reqs branch October 9, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant