Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implementation of Amplification Factor Transport(AFT) 2019b tranistion model #2422

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

sun5k
Copy link
Contributor

@sun5k sun5k commented Jan 15, 2025

Proposed Changes

Hi, all.

This PR is for implementing well known subsonic transition model (SA-AFT2019b).

Coder's SA-AFT2019b model is composed of the amplification factor and the logarithmic intermittency transport equation as shown below.
image

Current State

The primary implementation of the model has been completed and is now in the validation. The validation problems are refer : https://doi.org/10.2514/6.2023-3530 and https://doi.org/10.2514/6.2019-0039.

The transition onset location and the amplification factor field are slightly different. I'm still debugging and checking various things.

Validation Problem of Current State

Firstly, I'm trying the validation problem for 2-D problems (flat plate and NLF-0416 airfoil).
The current results are shown below.

S&K Flat plate from https://doi.org/10.2514/6.2023-3530

image

NLF-0416 airfoil from https://doi.org/10.2514/6.2023-3530
image

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Common/include/option_structure.hpp Fixed Show fixed Hide fixed
@@ -1407,6 +1451,25 @@
AddVolumeOutput("TURB_INDEX", "Turb_index", "PRIMITIVE", "Turbulence index");
break;

case TURB_TRANS_MODEL::AFT:
//nodes -> SetAFT_Wonder_Func(iPoint, HL, H12, dNdRet, Ret0, D_H12, l_H12, m_H12, kv, Rev, Rev0, F_growth, F_crit, PAF, Pg, Dg);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
SU2_CFD/src/solvers/CTransAFTSolver.cpp Fixed Show fixed Hide fixed
SU2_CFD/src/solvers/CTransAFTSolver.cpp Fixed Show fixed Hide fixed
SU2_CFD/src/solvers/CTransAFTSolver.cpp Fixed Show fixed Hide fixed
SU2_CFD/src/solvers/CTransAFTSolver.cpp Fixed Show fixed Hide fixed
SU2_CFD/src/solvers/CTransAFTSolver.cpp Fixed Show fixed Hide fixed
SU2_CFD/src/solvers/CTransAFTSolver.cpp Fixed Show fixed Hide fixed
AFT2017b
Test_Strain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant