Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added deprecated filter warnings #6

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Added deprecated filter warnings #6

wants to merge 2 commits into from
+71 −23

Conversation

andrewlimaza
Copy link

  • ENHANCEMENT: Added warnings for use of deprecated filters.

All Submissions:

@andrewlimaza
Added deprecated filter warnings
bbd7103 
* ENHANCEMENT: Added warnings for use of deprecated filters.
dparker1005
dparker1005 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@dparker1005 dparker1005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good assuming the next version is definitely 1.6. Not sure if we would bump to 2.0 due to the rebrand to PMPro Limit Logins

@andrewlimaza
Copy link
Author

I refactored it to rather be TBD instead - this makes sense to me. Thanks for catching this @dparker1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dparker1005 dparker1005 dparker1005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewlimaza @dparker1005