Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badly formatted ESM that was breaking Node 22 and 23 #260

Merged
merged 7 commits into from
Jan 14, 2025
Merged

Conversation

JReinhold
Copy link
Collaborator

@JReinhold JReinhold commented Jan 13, 2025

Closes #229
Closes sveltejs/cli#320
Closes sveltejs/cli#379
Closes storybookjs/storybook#30008

  1. Fixed some imports that were missing .js file extensions
  2. Changed tsconfig.json#moduleResolution to "nodenext" to enforce 👆 in the future, as per the Svelte docs
  3. Removed usage of @storybook/node-logger, which was just a wrapper of console.log, but was causing problems in ESM.
  4. Upgraded this repo to Node 22, to hopefully catch these issue in the future
  5. Formatted with Prettier

Published as canary version 4.2.1--canary.31bd578.0

Todo

  • Check if types are still working, especially exported components like Story, since it looks like the generated .d.ts-files are referencing Story.svelte.js files now, which doesn't really make sense.
  • Investigate if hand-written .d.ts files should be converted to .ts-files.

@JReinhold JReinhold self-assigned this Jan 14, 2025
@JReinhold JReinhold marked this pull request as ready for review January 14, 2025 20:47
@JReinhold JReinhold changed the title Fix badly formatted ESM, breaking Node 22 and 23 Fix badly formatted ESM that breaking Node 22 and 23 Jan 14, 2025
@JReinhold JReinhold changed the title Fix badly formatted ESM that breaking Node 22 and 23 Fix badly formatted ESM that was breaking Node 22 and 23 Jan 14, 2025
@JReinhold JReinhold added bug Something isn't working internal Changes only affect the internal API next Related to the next version labels Jan 14, 2025
@JReinhold JReinhold merged commit 06c81af into next Jan 14, 2025
7 checks passed
@JReinhold JReinhold deleted the fix-esm branch January 14, 2025 20:50
@JReinhold JReinhold added patch Increment the patch version when merged and removed internal Changes only affect the internal API labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next Related to the next version patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant