Fix missing #pragma once and add linter

stevenlovegrove · Dec 12, 2023 · ede517e · ede517e
1 parent 0cb6dc3
commit ede517e
Show file tree

Hide file tree

Showing 8 changed files with 27 additions and 5 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -9,3 +9,17 @@ repos:
     rev: v14.0.0
     hooks:
       - id: clang-format
+  - repo: local
+    hooks:
+      - id: pragma-once
+        name: pragma once check
+        entry: "#pragma once"
+        language: pygrep
+        files: \.h$
+        args: [--negate]
+        exclude: |
+          (?x)(
+            components/pango_core/include/pangolin/utils/picojson.h|
+            (components/pango_opengl/shaders/.*.glsl.h$)|
+            components/pango_opengl/src/stb_truetype.h
+          )
diff --git a/components/pango_context/include/pangolin/drawable/drawn_image.h b/components/pango_context/include/pangolin/drawable/drawn_image.h
@@ -1,3 +1,5 @@
+#pragma once
+
 #include <pangolin/color/colormap.h>
 #include <pangolin/drawable/drawn_checker.h>
 #include <pangolin/layer/draw_layer.h>

diff --git a/components/pango_core/include/pangolin/factory/factory_help.h b/components/pango_core/include/pangolin/factory/factory_help.h
@@ -1,3 +1,5 @@
+#pragma once
+
 #include <pangolin/factory/factory_registry.h>
 
 #include <iostream>

diff --git a/components/pango_core/include/pangolin/testing/eigen.h b/components/pango_core/include/pangolin/testing/eigen.h
@@ -1,3 +1,5 @@
+#pragma once
+
 #include <catch2/catch_test_macros.hpp>
 #include <sophus/common/common.h>
 

diff --git a/components/pango_core/include/pangolin/utils/bitmask.h b/components/pango_core/include/pangolin/utils/bitmask.h
@@ -1,3 +1,5 @@
+#pragma once
+
 // Modified version of https://gpfault.net/posts/typesafe-bitmasks.txt.html
 // (public domain)
 

diff --git a/components/pango_core/include/pangolin/utils/parse.h b/components/pango_core/include/pangolin/utils/parse.h
@@ -1,3 +1,5 @@
+#pragma once
+
 /* This file is part of the Pangolin Project.
  * http://github.com/stevenlovegrove/Pangolin
  *
@@ -25,9 +27,6 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#ifndef PANGOLIN_PARSE_H
-#define PANGOLIN_PARSE_H
-
 #include <cctype>
 #include <string>
 
@@ -108,5 +107,3 @@ inline int ParseToken(
   }
 
 }  // namespace pangolin
-
-#endif  // PANGOLIN_PARSE_H
diff --git a/components/pango_vars/include/pangolin/var/varinit.h b/components/pango_vars/include/pangolin/var/varinit.h
@@ -1,3 +1,5 @@
+#pragma once
+
 #include <pangolin/var/varvalue.h>
 
 #include <cstring>

diff --git a/components/pango_windowing/include/pangolin/windowing/X11GlContext.h b/components/pango_windowing/include/pangolin/windowing/X11GlContext.h
@@ -0,0 +1 @@
+#pragma once