Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifecycle identity refactor #428

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Lifecycle identity refactor #428

merged 10 commits into from
Nov 13, 2023

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Nov 13, 2023 •
edited by pastuxso
Loading

Closes: #426

  1. Treat cell IDs similar to the way we handle generated names.
  2. Move biz logic into document.
  3. Separate ulid spec and identity impl.
  4. Brings lifecycle identity to runme fmt (solves Add document/cell identity options to fmt sub-command #426)

Missing (not merge critical):

  • Tests for identityResolver itself (covered mostly by package integration unit tests)
  • Bring back v0.0 overwrite protection
  • Consider todos on ID semantics, specifically whether or not to retain invalid ULIDs in Cell IDs

@sourishkrout sourishkrout marked this pull request as draft November 13, 2023 13:26
@sourishkrout sourishkrout marked this pull request as ready for review November 13, 2023 15:40
@pastuxso pastuxso mentioned this pull request Nov 13, 2023
Closed
10 tasks
@pastuxso pastuxso linked an issue Nov 13, 2023 that may be closed by this pull request
Persistent id for every cell #408
Closed
10 tasks
@sourishkrout sourishkrout mentioned this pull request Nov 13, 2023
Merged
pastuxso
pastuxso approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@pastuxso pastuxso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sourishkrout sourishkrout merged commit d6003e1 into main Nov 13, 2023
4 checks passed
@sourishkrout sourishkrout deleted the lifecycle-identity branch November 13, 2023 17:13
@sourishkrout sourishkrout mentioned this pull request Nov 13, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastuxso pastuxso pastuxso approved these changes

Assignees

@sourishkrout sourishkrout

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add document/cell identity options to fmt sub-command Persistent id for every cell
2 participants
@sourishkrout @pastuxso