-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Includes Markdown AST Metadata into non-code Cells #388
Conversation
e43b9ec
to
97b3836
Compare
d1caec3
to
deb04f5
Compare
I'm undecided on using the |
@sourishkrout, I believe we could implement a nested structure, though it would necessitate significant modifications to our existing one. Alternatively, we could incorporate a stringified JSON under the key What do you think about the following structure? {
"runme.dev/ast": {
"Kind": "Paragraph",
"RawText": "Some content with [Link1](https://example1.com \"Link title 1\") [Link2](https://example2.com \"Link title2\")",
"Children": [
{
"Kind": "Text",
"Text": "Some content with "
},
{
"Destination": "https://example1.com",
"Kind": "Link",
"Title": "Link title 1"
},
{
"Kind": "Text",
"Text": " "
},
{
"Destination": "https://example2.com",
"Kind": "Link",
"Title": "Link title2"
},
{
"Kind": "Text",
"Text": "Link1"
},
{
"Kind": "Text",
"Text": "Link2"
}
]
}
} |
@pastuxso I like it better 👍 . Scopes/namespaces it under a single property. |
7b35af6
to
0ae8a59
Compare
Let's figure out what's left to get this merged. We should probably just have a convo (after standup) or something about it. |
46ec3f3
to
f95881b
Compare
f95881b
to
6efcce9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM. I saw some minor issues inside the AST info. However, let's merge for now and circle back later.
Metadata sample output: