Skip to content

Commit

Permalink
Add TODO about stdin handling
Browse files Browse the repository at this point in the history
  • Loading branch information
adambabik committed Sep 23, 2024
1 parent 8804b90 commit a74e752
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/runnerv2client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ func (c *Client) executeProgram(
}

if stdin := opts.Stdin; !isNil(stdin) {
// TODO(adamb): reimplement it. There should be a singleton
// handling and forwarding the stdin. The current implementation
// does not temrinate multiple stdin readers in the case of
// running multiple commands using "beta run command1 command2 ... commandN".
go func() {
defer func() {
c.logger.Info("finishing reading stdin")
Expand Down

0 comments on commit a74e752

Please sign in to comment.