fixes extra spaces when there is no metadata

stateful · Nov 7, 2023 · 796a444 · 796a444
1 parent 17c42f1
commit 796a444
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/internal/document/editor/editorservice/service.go b/internal/document/editor/editorservice/service.go
@@ -94,7 +94,12 @@ func (s *parserServiceServer) Serialize(_ context.Context, req *parserv1.Seriali
 		raw := req.Notebook.Metadata[frontMatterKey]
 
 		_, info := document.ParseFrontmatterWithIdentity(raw, false)
-		req.Notebook.Metadata[frontMatterKey] = info.GetRaw()
+		raw = info.GetRaw()
+		if raw == "" {
+			delete(req.Notebook.Metadata, frontMatterKey)
+		} else {
+			req.Notebook.Metadata[frontMatterKey] = raw
+		}
 	}
 
 	data, err := editor.Serialize(&editor.Notebook{

diff --git a/internal/document/editor/editorservice/service_test.go b/internal/document/editor/editorservice/service_test.go
@@ -223,7 +223,7 @@ Some content
 	})
 
 	t.Run("Frontmatter Identity RUNME_IDENTITY_UNSPECIFIED Empty", func(t *testing.T) {
-		content := ""
+		content := "# H1"
 
 		dResp, err := client.Deserialize(
 			context.Background(),
@@ -233,7 +233,7 @@ Some content
 		)
 
 		assert.NoError(t, err)
-		assert.Len(t, dResp.Notebook.Cells, 0)
+		assert.Len(t, dResp.Notebook.Cells, 1)
 		sResp, err := client.Serialize(
 			context.Background(),
 			&parserv1.SerializeRequest{
@@ -245,6 +245,6 @@ Some content
 		)
 
 		assert.NoError(t, err)
-		assert.Equal(t, "", string(sResp.Result))
+		assert.Equal(t, content, string(sResp.Result))
 	})
 }