Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignore templates in Chart dependencies based on ignore paths #667

Merged
merged 2 commits into from
Jan 18, 2024
Merged

feat: ignore templates in Chart dependencies based on ignore paths #667

merged 2 commits into from
Jan 18, 2024

Conversation

Trojan295
Copy link
Contributor

Solves #575

@Trojan295 Trojan295 requested a review from janisz as a code owner November 23, 2023 12:52
janisz
janisz reviewed Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you add tests to validate it's working as expected in the issue?

@janisz janisz added the bug Something isn't working label Nov 23, 2023
@Trojan295
Copy link
Contributor Author

Trojan295 commented Nov 23, 2023 •
edited
Loading

@janisz I added a test.

I also saw that the ignorePaths are always passed to the CreateContexts in absolute path, while the args might be absolute or relative. You can see this creates a bug by comparing these commands, which yield a different result on main:

kube-linter lint $PWD/tests/testdata --ignore-paths $PWD/tests/testdata

kube-linter lint tests/testdata --ignore-paths $PWD/tests/testdata

The PR also addresses this.

@janisz janisz self-requested a review December 21, 2023 17:00
@janisz janisz merged commit e0225f4 into stackrox:main Jan 18, 2024
7 checks passed
@janisz
Copy link
Collaborator

janisz commented Jan 18, 2024

Thank you!
I'm sorry for a long delay.

@janisz janisz mentioned this pull request Jan 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Trojan295 @janisz