Skip to content

Commit

Permalink
chore: bump golangci-lint to v1.63.4
Browse files Browse the repository at this point in the history
  • Loading branch information
stehessel committed Jan 7, 2025
1 parent 1032818 commit b95e442
Show file tree
Hide file tree
Showing 4 changed files with 353 additions and 326 deletions.
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ linters:
# - gochecknoinits
# - gocognit
# - goconst
- exportloopref
- gocritic
# - gocyclo
# - godot
Expand Down
1 change: 1 addition & 0 deletions pkg/templates/pdbminavailable/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ func minAvailableCheck(lintCtx lintcontext.LintContext, object lintcontext.Objec
// Calulate the actual value of the MinAvailable with respect to the Replica count if a percentage is set
pdbMinAvailable = int(math.Ceil(float64(replicas) * (float64(value) / float64(100))))
}
//nolint:gosec // Integer conversion should be safe here since the kube api uses int32.
if replicas <= int32(pdbMinAvailable) {
results = append(results, diagnostic.Diagnostic{
Message: fmt.Sprintf("The current number of replicas for deployment %s is equal to or lower than the minimum number of replicas specified by its PDB.", dl.GetName()),
Expand Down
Loading

0 comments on commit b95e442

Please sign in to comment.