Update color of targets and center

[ZoeJacky]

When "Turn target to green when reached" is selected and "Delay before central target display(secs)" > 0s:

• Once the outer target is reached, it will turn to green until the next central target display.
• But when the central target is reached, it will just turn to gray.

Could you confirm if this behavior aligns with the expected functionality?

[lkeegan]

thanks, looks good! some minor comments/suggestions.

regarding the expected functionality, for the outer targets it looks good, but I guess it would make sense to do the same thing for the central target, i.e. it should also go green after it is reached, until the next target is displayed

[lkeegan]

Also the tests are failing in CI - I think you'll need to add your new option to trial_dict in this test, as that is supposed to contain all valid keys:

vstt/tests/test_trial.py

Lines 48 to 51 in 8a014de

	def test_import_trial() -> None:
	default_trial = vstt.trial.default_trial()
	trial_dict = {
	"weight": 2,

[ZoeJacky]

thanks, looks good! some minor comments/suggestions.

regarding the expected functionality, for the outer targets it looks good, but I guess it would make sense to do the same thing for the central target, i.e. it should also go green after it is reached, until the next target is displayed

thanks, looks good! some minor comments/suggestions.

regarding the expected functionality, for the outer targets it looks good, but I guess it would make sense to do the same thing for the central target, i.e. it should also go green after it is reached, until the next target is displayed

update:
When "Turn target to green when reached" is selected and the related delay time > 0s:
Once the outer or central target is reached, it will turn to green until the next central or outer target display.

[lkeegan]

thanks - behaviour looks good now, one suggestion to simplify the logic.

also there are still tests that need to be updated

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud