Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): Update swagger-ui endpoint with springfox 3.0.0 upgrade #1019

Closed
wants to merge 1 commit into from

Conversation

j-sandy
Copy link
Contributor

@j-sandy j-sandy commented Feb 5, 2024

With upgrade of springfox from 2.9.2 to 3.0.0, a breaking change has been introduced in the form of new endpoint for swagger-ui (/swagger-ui/index.html). This change caused SwaggerTest.swaggerUiIsPresent test to fail. In order to fix this test, updating the swagger-ui endpoint as /swagger-ui/index.html.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • cada70b: Fix(test): Update swagger-ui endpoint with springfox 3.0.0 upgrade

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

With upgrade of springfox from 2.9.2 to 3.0.0, a breaking [change](http://springfox.github.io/springfox/docs/current/#changes-in-swagger-ui) has been introduced in the form of new endpoint for swagger-ui (/swagger-ui/index.html). This change caused the `SwaggerTest.swaggerUiIsPresent` test to fail. In order to fix this test, updating the swagger-ui endpoint as `/swagger-ui/index.html`.
@j-sandy j-sandy changed the title Fix(test): Update swagger-ui endpoint with springfox 3.0.0 upgrade fix(test): Update swagger-ui endpoint with springfox 3.0.0 upgrade Feb 5, 2024
@dbyron-sf
Copy link
Contributor

included in #1018

@dbyron-sf dbyron-sf closed this Feb 5, 2024
@j-sandy j-sandy deleted the spring-3 branch February 6, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants