fix(google): Add partner metadata on instanceTemplate properties #6334
+99
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,11 +61,13 @@ public GoogleComputeOperationRequest<Compute.InstanceTemplates.Insert> insert( | |||
| return requestFactory.wrapOperationRequest(request, "insert"); | |||
| } | |||
|
|
|||
| public PaginatedComputeRequest<Compute.InstanceTemplates.List, InstanceTemplate> list() { | |||
| public PaginatedComputeRequest<Compute.InstanceTemplates.List, InstanceTemplate> list( | |||
| String view) { | |||
There was a problem hiding this comment.
Is this api used anywhere else? I see the one spot below in the abstract caching agent that passes a fixed value of "FULL", but no place else this list call is updated?
There was a problem hiding this comment.
IF it's only ever called in that ONE operation - why not just add that as a fixed value here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloning a server group using the UI. The resourceManagerTags and partnerMetadata are not populated even if the deployment is configured with resourceManagerTags and partnerMetadata.
In clouddriver we include the resourceManagerTags under the instanceTemplate properties but by default the partnerMetadata is not included. See https://cloud.google.com/sdk/gcloud/reference/beta/compute/instance-templates/list
The fix only set the view option to "FULL". This ensure the partnerMetadata is included in the instanceTemplate properties.
Deck PR: spinnaker/deck#10161