Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CircleCI in favour for GitHub Actions #177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove CircleCI in favour for GitHub Actions #177

wants to merge 1 commit into from

Conversation

shaikhu
Copy link
Contributor

@shaikhu shaikhu commented Dec 5, 2024

@paul-botsco-2-0 paul-botsco-2-0 bot added the 😍 cla signed The CLA is signed label Dec 5, 2024
bhamail
bhamail requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t want to be a blocker, but could we wait to commit this PR until after a successful release has occurred using GitHub Actions?

@shaikhu
Copy link
Contributor Author

shaikhu commented Dec 5, 2024

I don’t want to be a blocker, but could we wait to commit this PR until after a successful release has occurred using GitHub Actions?

Sounds sensible to me 👍

@paul-botsco-2-0 paul-botsco-2-0 bot added the 😧 commits missing verification Some commits are not signed - this must be resolved label Dec 17, 2024
@paul-botsco-2-0
Copy link

Thanks for the contribution. Unfortunately some of your commits don't meet our standards. All commits must be signed and have author information set.

The commits to review are:

See Signed Commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhamail bhamail bhamail requested changes

Assignees
No one assigned
Labels
😧 commits missing verification Some commits are not signed - this must be resolved 😍 cla signed The CLA is signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove CircleCI configuration - now using GitHub Actions
2 participants
@shaikhu @bhamail