Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack build #295

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix stack build #295

merged 1 commit into from
Jul 23, 2024

Conversation

ulidtko
Copy link
Contributor

@ulidtko ulidtko commented Jul 23, 2024

Hey @jappeace

After #292, stack build on master says Stack failed to construct a build plan. — I'm fixing that by suitably declaring extra-deps (which are packages missing from Stackage), see in-source comments.

Further, lts-20 is not a valid resolver (Exception while reading snapshot from lts-20: YAML exception) — so I'm specifying a correct one. Also checking in the lockfile; it should be in git.

If you only want to support cabal build — that's fine; then drop the stack.yaml. Adding stack build to CI might be another good idea.

With this patch, stack build produces a keter executable out-of-the-box.

@jappeace
Copy link
Collaborator

I've no issue suppoting stack it's just hard to maintain for me on nixos :s
I'm not sure why it's so difficult for nixos peeps to support stack, every other program under the sun works

@jappeace jappeace merged commit 6b7f1e4 into snoyberg:master Jul 23, 2024
9 checks passed
@ulidtko ulidtko deleted the fix/stack-build branch July 23, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants