Ensure first window is always small #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change affects windowing apps e.g. Lake Loader. Before this change, the first window was a random size, to avoid write conflicts between several loaders finishing their windows at similar times. After this change, the first window is still random, but sized in the ranged 25% to 50% of the regular window size. This was shown in Lake Loader to give a smoother starting cpu profile, and it prevents the loader from pulling in too many events into the first window.
pondzix
approved these changes
Jan 13, 2025
| @@ -62,7 +67,7 @@ object EventProcessingConfig { | |||
| for { | |||
| random <- Random.scalaUtilRandom | |||
| factor <- random.nextDouble | |||
| } yield TimedWindows(duration, factor, numEagerWindows) | |||
| } yield TimedWindows(duration, 0.25 * (1.0 + factor), numEagerWindows) | |||
There was a problem hiding this comment.
I think there is betweenDouble in Random. Would that work here and maybe make the range a bit more clear?
There was a problem hiding this comment.
Well spotted. Nice idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change affects windowing apps e.g. Lake Loader.
Before this change, the first window was a random size, to avoid write conflicts between several loaders finishing their windows at similar times. After this change, the first window is still random, but sized in the ranged 25% to 50% of the regular window size. This was shown in Lake Loader to give a smoother starting cpu profile, and it prevents the loader from pulling in too many events into the first window.