Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating mphys wrapper to work w/ MPhys 2.0 #337

Merged
merged 6 commits into from
Dec 13, 2024
Merged

Updating mphys wrapper to work w/ MPhys 2.0 #337

merged 6 commits into from
Dec 13, 2024

Conversation

timryanb
Copy link
Collaborator

@timryanb timryanb commented May 17, 2024 •
edited
Loading

  • Refactored builder class to use new mphys import procedures and variable naming convention
  • To be merged in when after MPhys release
  • CI expected to fail until MPhys 2.0 release

@timryanb timryanb requested review from kejacobson and A-CGray May 17, 2024 13:38
@timryanb timryanb marked this pull request as ready for review December 11, 2024 23:24
@timryanb timryanb mentioned this pull request Dec 12, 2024
Merged
kejacobson
kejacobson reviewed Dec 13, 2024
View reviewed changes
Copy link
Contributor

@kejacobson kejacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Only found a few places where search and replace keywords in the middle of a variable name were changed to all caps and should remain lower case.

funtofem/mphys/mphys_meld.py Outdated Show resolved Hide resolved
funtofem/mphys/mphys_meldthermal.py Outdated Show resolved Hide resolved
funtofem/mphys/mphys_meldthermal.py Outdated Show resolved Hide resolved
@timryanb timryanb requested a review from kejacobson December 13, 2024 19:06
@timryanb timryanb merged commit c8e9bd9 into smdogroup:master Dec 13, 2024
6 checks passed
@timryanb timryanb deleted the mphys-2.0 branch December 13, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kejacobson kejacobson kejacobson approved these changes

@A-CGray A-CGray Awaiting requested review from A-CGray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timryanb @kejacobson