Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early Stopping for Coupled Driver #243

Closed
wants to merge 13 commits into from

Conversation

sean-engelstad
Copy link
Contributor

@sean-engelstad sean-engelstad commented Oct 25, 2023

  • change preconditioner_steps to uncoupled_steps (never should have been coupled preconditioner_steps as that is a misnomer => we just hadn't changed it yet)
  • add early stopping criterion to funtofem_nlbgs_driver (coupled driver)
  • min_steps argument defaults to uncoupled_steps
  • convergence tolerances added to discipline scenarios esp. FUN3D interface
  • Could also add it to the TACS interface later (but we don't really use that for the early stopping criterion as the linear solve converges like 99.9% of the time)
  • Early stopping will not work for the unsteady scenarios as the adjoints don't work for certain solvers (FUN3D) if the analysis exits early (also it doesn't really make sense to stop early in an unsteady scenario)
  • NOTE: still need to test this out so marking as draft until it is tested
  • Also note => my master branch has commits that didn't get discarded but they are equivalent to old commits so don't change the code. Please disregard these.

@sean-engelstad sean-engelstad added the enhancement New feature or request label Oct 25, 2023
@sean-engelstad
Copy link
Contributor Author

Not able to test this at the moment, the only thing left is to run jobs with it and prove that it works after correcting some code inside FUN3D.

@sean-engelstad
Copy link
Contributor Author

Included in PR #249

@sean-engelstad sean-engelstad deleted the early_stopping branch November 13, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants