Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for imperial units #1103

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devbyaccident
Copy link

From #795, which was closed without review.

This adds support for Fahrenheit handling to the climate entity, so now the current temperature from the temperature sensor will properly match the target temperature within the climate display in terms of units.

Closes #1042

Co-authored-by: Kevin Brown-Silva <[email protected]>
@jrunning
Copy link

jrunning commented Aug 4, 2023

I copied this into my own HA instance and it works great. I hope this PR can get some attention from the maintainer(s)!

@TheAppleFreak
Copy link

+1 for it working on my own instance

@seajhawk
Copy link

seajhawk commented Aug 5, 2023

Tested in my instance of HA as well.

Thanks @devbyaccident!

@something-completely-random

Thanks for this, works for me.

@TheAppleFreak
Copy link

Noticed there was an update recently to the component, so I figured it's worth bumping this again to maybe get it looked at again.

@ardichoke
Copy link

Cherry-picked this change into my own fork and am running it on my HA install. It seems to work fine so far. Would be nice to see this get merged.

@dylan-travis
Copy link

This works for me, thank you 👍

TheAppleFreak added a commit to TheAppleFreak/SmartIR that referenced this pull request May 22, 2024
Ports over the changes from [this pull request in the original SmartIR repo](smartHomeHub#1103), made by @devbyaccident and @kevin-brown.
@TheAppleFreak
Copy link

Regarding that last merge, there's one additional change that needs to be made due to changes in HA Core since this PR was written: TEMP_FAHRENHEIT needs to be changed to UnitOfTemperature.FAHRENHEIT instead, otherwise it'll spit out deprecation notices in the HA logs.

@devbyaccident
Copy link
Author

Regarding that last merge, there's one additional change that needs to be made due to changes in HA Core since this PR was written: TEMP_FAHRENHEIT needs to be changed to UnitOfTemperature.FAHRENHEIT instead, otherwise it'll spit out deprecation notices in the HA logs.

Good callout. I'm not sure when I'll get a chance to work on this, day job been keeping me pretty busy lately, but hopefully will be able to take a look before end of June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for imperial units... again
7 participants