-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for imperial units #1103
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Kevin Brown-Silva <[email protected]>
I copied this into my own HA instance and it works great. I hope this PR can get some attention from the maintainer(s)! |
+1 for it working on my own instance |
Tested in my instance of HA as well. Thanks @devbyaccident! |
Thanks for this, works for me. |
Noticed there was an update recently to the component, so I figured it's worth bumping this again to maybe get it looked at again. |
Cherry-picked this change into my own fork and am running it on my HA install. It seems to work fine so far. Would be nice to see this get merged. |
This works for me, thank you 👍 |
Ports over the changes from [this pull request in the original SmartIR repo](smartHomeHub#1103), made by @devbyaccident and @kevin-brown.
Regarding that last merge, there's one additional change that needs to be made due to changes in HA Core since this PR was written: |
Good callout. I'm not sure when I'll get a chance to work on this, day job been keeping me pretty busy lately, but hopefully will be able to take a look before end of June. |
From #795, which was closed without review.
This adds support for Fahrenheit handling to the climate entity, so now the current temperature from the temperature sensor will properly match the target temperature within the climate display in terms of units.
Closes #1042