Sync flake with nixpkg #2218
Open
Sync flake with nixpkg #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncs changes from be04a5d17ecc374056cafa82e19a0086190dc0bf.
alerque
added
todo
tooling
doronbehar
approved these changes
Jan 18, 2025
Comment on lines
+82
to
+93
| buildInputs = [ | ||
| finalAttrs.finalPackage.passthru.luaEnv | ||
| cargo-edit | ||
| harfbuzz | ||
| icu | ||
| fontconfig | ||
| libiconv | ||
| libxslt | ||
| stylua | ||
| taplo | ||
| typos | ||
| ]; |
There was a problem hiding this comment.
This is one of my painful points in the new nix formatting, but I guess I'll have to live with it :).
There was a problem hiding this comment.
My beef is it did not apply the same style to all elements, e.g. luaPackages and configureFlags did not get formatted the same way buildInputs and others did. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does 91ca987 look right @doronbehar?
c.f. NixOS/nixpkgs#373209