Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin-ize some more tests #13813

Conversation

jamesonwilliams
Copy link
Contributor

Contributor checklist

  • MacBook Pro M3 (test suite)
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Converting a few more unit tests to Kotlin:

app/src/test/java/org/thoughtcrime/securesms/recipients/RecipientExporterTest.java
app/src/test/java/org/thoughtcrime/securesms/recipients/RecipientUtilTest.java
app/src/test/java/org/thoughtcrime/securesms/util/DelimiterUtilTest.java
core-util/src/test/java/org/signal/core/util/concurrent/LatestPrioritizedSerialExecutorTest.java
libsignal-service/src/test/java/org/whispersystems/signalservice/api/services/DonationsServiceTest.java

Also migrated from Mockito to MocK where appropriate

Verified operation of modified tests:

./gradlew \
    :Signal-Android:testPlayProdDebugUnitTest \
    :core-util:testDebugUnitTest \
    :libsignal-service:test

@jamesonwilliams jamesonwilliams force-pushed the kotlinize-some-more-tests branch from 5e4e482 to 46ed43b Compare November 22, 2024 21:20
@jamesonwilliams jamesonwilliams marked this pull request as ready for review November 22, 2024 21:39
@greyson-signal
Copy link
Contributor

Thank you very much!

TheTechZone pushed a commit to Cerenia/Signal-Android that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants