Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Chat search doesn't work well in many cases with Japanese IMEs #13467

Closed
wants to merge 1 commit into from

Conversation

fumiakiy
Copy link
Contributor

@fumiakiy fumiakiy commented Mar 9, 2024

Contributor checklist

  • Samsung Galaxy S22+ One UI 6.0 Android 14
  • AVD Pixel 6a Android 14 Google Play
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

In in-conversation search, you almost cannot use the search function in Japanese because the Gboard (and possibly other keyboards) keeps closing when you type a key. The very similar behavior is there for the emoji search in the chat input panel
as well. See the screen recordings below for details.

There are quite a few user reviews in Japanese in Google Play that submit the issue. I pasted the screenshots of some of the reviews.

Steps to reproduce the bug

  1. Set up the device so your Gboard opens in Japanese mode (qwerty)
  2. Open Signal, go to a chat (1:1 or group)
  3. Menu > Search
  4. Enter a consonant (b for example)

Observed:
Keyboard closes and the full-width "b" is committed in the edittext. Nothing will be found for the character (in most cases) in the search results.

Expected:
Keyboard stays open and the character is not committed, and the search doesn't start. Keep entering a valid word and search should work.

Screen recordings

Bug in chat search

pr-before.mp4

Bug in emoji search

pr-before-2.mp4

After the fix in this PR

pr-fixed.mp4
pr-fixed-2.mp4

@fumiakiy
Copy link
Contributor Author

fumiakiy commented Mar 9, 2024

Here are some of the reviews in Google Play that point out the bug

Screen Shot 2024-03-08 at 5 08 21 PM Screen Shot 2024-03-08 at 5 07 51 PM
Screen Shot 2024-03-08 at 5 07 07 PM Screen Shot 2024-03-08 at 5 06 45 PM

@greyson-signal
Copy link
Contributor

Thank you! We'll put this in 7.2 provided we don't experience any problems with it (this is definitely a finnicky area of the codebase!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants