Fix: Chat search doesn't work well in many cases with Japanese IMEs #13467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234
syntaxDescription
In in-conversation search, you almost cannot use the search function in Japanese because the Gboard (and possibly other keyboards) keeps closing when you type a key. The very similar behavior is there for the emoji search in the chat input panel
as well. See the screen recordings below for details.
There are quite a few user reviews in Japanese in Google Play that submit the issue. I pasted the screenshots of some of the reviews.
Steps to reproduce the bug
Observed:
Keyboard closes and the full-width "b" is committed in the edittext. Nothing will be found for the character (in most cases) in the search results.
Expected:
Keyboard stays open and the character is not committed, and the search doesn't start. Keep entering a valid word and search should work.
Screen recordings
Bug in chat search
pr-before.mp4
Bug in emoji search
pr-before-2.mp4
After the fix in this PR
pr-fixed.mp4
pr-fixed-2.mp4