-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sparkle with glow #318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Nice! I think it would be really useful here to give a bit of background on |
mrobinson
requested changes
Sep 25, 2024
mrobinson
requested changes
Sep 25, 2024
mrobinson
reviewed
Sep 25, 2024
sagudev
commented
Sep 25, 2024
mrobinson
approved these changes
Sep 25, 2024
sagudev
commented
Sep 25, 2024
sagudev
commented
Oct 1, 2024
Signed-off-by: sagudev <[email protected]>
This is breaking change and it will need version bump! |
mrobinson
approved these changes
Oct 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sparkle
is a GL crate that is part of the Servo project, but mostly unmaintained. We would like to archive it and replace it withglow
, that is actively maintained and used bywgpu
and the wider Rust community.Part of servo/servo#33539