Skip to content

Commit

Permalink
Upgrade redis chart version (#483)
Browse files Browse the repository at this point in the history
  • Loading branch information
Scott Cabrinha authored Sep 28, 2021
1 parent b052d39 commit 1cd02c0
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 7 deletions.
6 changes: 3 additions & 3 deletions sentry/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
dependencies:
- name: redis
repository: https://charts.bitnami.com/bitnami
version: 9.3.2
version: 15.3.2
- name: kafka
repository: https://charts.bitnami.com/bitnami
version: 12.0.0
Expand All @@ -17,5 +17,5 @@ dependencies:
- name: nginx
repository: https://charts.bitnami.com/bitnami
version: 9.3.3
digest: sha256:efb99c6fab0a3ee5d886afaa36c3f6924ace571570cdfbdf6ce83c972572640d
generated: "2021-07-17T03:13:33.389439+02:00"
digest: sha256:b6d9b1f69141cf564b7ea14617967d8d642ff80a0230c4563582da39bc323d2f
generated: "2021-09-14T13:44:16.162057-07:00"
4 changes: 2 additions & 2 deletions sentry/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@ apiVersion: v2
name: sentry
description: A Helm chart for Kubernetes
type: application
version: 11.9.0
version: 12.0.0
appVersion: 21.8.0
dependencies:
- name: redis
repository: https://charts.bitnami.com/bitnami
version: 9.3.2
version: 15.3.2
condition: redis.enabled
- name: kafka
repository: https://charts.bitnami.com/bitnami
Expand Down
11 changes: 10 additions & 1 deletion sentry/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
## Upgrading from 11.x.x version of this Chart to 12.0.0

Redis chart was upgraded to newer version. If you are using external redis, you don't need to do anything.

Otherwise, when upgrading to chart version 12.x.x from 11.x.x you need to either run `helm upgrade` with `--force` flag, or prior to upgrade delete statefulsets for redis master and redis slave. Then run upgrade and it will roll out new statefulsets. Your master redis data will not be lost (PVC is not deleted when you delete statefulset). Your redis slave will now be named redis replica and you can delete PVCs that were used by redis slave after the upgrade.

## Upgrading from 10.x.x version of this Chart to 11.0.0

If you were using clickhouse tabix externally, we disabled it per default.

### Upgrading from deprecated 9.0 -> 10.0 Chart

As this chart runs in helm 3 and also tries its best to follow on from the original Sentry chart. There are some steps that needs to be taken in order to correctly upgrade.
Expand Down Expand Up @@ -110,4 +120,3 @@ Note: If you need to run or cannot avoid running sentry-worker and sentry-web on
So you would want to create and use a `StorageClass` with a supported volume driver like [AWS EFS](https://github.com/kubernetes-sigs/aws-efs-csi-driver)

Its also important having `connect_to_reserved_ips: true` in the symbolicator config file, which this Chart defaults to.

Binary file modified sentry/charts/clickhouse-3.0.0.tgz
Binary file not shown.
Binary file added sentry/charts/redis-15.3.2.tgz
Binary file not shown.
Binary file removed sentry/charts/redis-9.3.2.tgz
Binary file not shown.
5 changes: 4 additions & 1 deletion sentry/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ sentry:
livenessProbe:
enabled: false
periodSeconds: 60
timeoutSeconds: 10
timeoutSeconds: 10
failureThreshold: 3
sidecars: [ ]
volumes: [ ]
Expand Down Expand Up @@ -729,6 +729,9 @@ externalKafka:

redis:
enabled: true
auth:
enabled: false
sentinel: false
nameOverride: sentry-redis
usePassword: false
## Just omit the password field if your redis cluster doesn't use password
Expand Down

0 comments on commit 1cd02c0

Please sign in to comment.