Sensu-Go-Ctl support for windows platform #59
Conversation
|
@derekgroh overall I'm 👍 for this, just a small question. Thanks for adding the windows support here! |
There was a problem hiding this comment.
@majormoses This looks reasonable to me. Approving but will hold off merging until you can comment as well.
|
So a limitation of two different testing tools is there is no method through appveyor to test ctl recipes as it requires a converged server to make a call against. (Unless there is a public instance Sensu runs that we could make the call against?) Should this be addressed as part of this PR or addressed later as the tooling allows? |
|
@derekgroh this is getting pretty big at this point so I'd like to be able to merge for you soon. Can you explain the appveyor problem a little more? Would there be a problem just using the same single instance on appveyor to run as the server + ctl for tests? |
|
@webframp Sensuctl suite tests a connection to a backend to confirm it is configured correctly, unless there is a way to mock it without a backend being available. Otherwise appveyor has no method to test this suite, because it can not launch a backend to test against. I can explain further in Slack if you want. |
|
@derekgroh Added #68 to remember to come back and address this testing |
Pull Request Checklist
#50
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Cookstyle (rubocop) passes
Foodcritic passes
Rspec (unit tests) passes
Fails to detect the
Download Sensuctlpowershell_script, but strings match.Inspec (integration tests) passes
New Features
Added a Testing Artifact as either an automated test or a manual artifact on the PR.
Added documentation for it to the
README.mdPurpose
Provide a method for windows entities to install and configure the Sensuctl.exe application.
Known Compatibility Issues
This may be held until packaging for Sensuctl.exe is presented in a more Windows friendly manner avoiding the additional steps to obtain the exe, which would require modification to the resource and unit tests.