Clean up unused code #753
Draft
Clean up unused code #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice clean up. might be good to use a tool like https://github.com/jendrikseipp/vulture to check for stray bits of code |
fgregg
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the recommendations for code cleanup as outlined in #705. Note that it removes the models and other code for the apps to be removed (
areaandgeosite) and adds migrations to clean up the tables. We need to deploy the apps in this empty state so the tables are removed from the deployed databases, then we can remove the apps.The full diff is huge because I removed a ton of static files that we no longer use. This diff covers the removal of the apps.
Testing Instructions