Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for scikit-learn 1.6 #504

Merged
merged 20 commits into from
Jan 12, 2025
Merged

Add support for scikit-learn 1.6 #504

merged 20 commits into from
Jan 12, 2025

Conversation

sebp
Copy link
Owner

@sebp sebp commented Dec 21, 2024

Checklist

  • pytest passes
  • tests are included
  • code is well formatted
  • documentation renders correctly

What does this implement/fix? Explain your changes
Adds support for scikit-learn 1.6 and drops support for previous versions.

@sebp
Copy link
Owner Author

sebp commented Dec 28, 2024

The failing test test_forest.py::test_fit_missing_values is due to scikit-learn/scikit-learn#30554

@AYUSH27112021
Copy link

@sebp if you require I am happy to collaborate

@sebp
Copy link
Owner Author

sebp commented Dec 29, 2024

@AYUSH27112021 Thanks for your kind offer.

The code in the sklearn-1-6 branch already works. I still have to check if there are any new APIs that I need to account for.

@sebp sebp force-pushed the sklearn-1-6 branch 2 times, most recently from c694839 to 9abf0e1 Compare January 4, 2025 10:33
Copy link

codacy-production bot commented Jan 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.14% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (5ab06da) 3564 3534 99.16%
Head commit (83618d4) 3568 (+4) 3543 (+9) 99.30% (+0.14%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#504) 80 80 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (5ab06da) to head (83618d4).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   98.23%   98.51%   +0.28%     
==========================================
  Files          37       37              
  Lines        3564     3568       +4     
  Branches      472      470       -2     
==========================================
+ Hits         3501     3515      +14     
+ Misses         30       25       -5     
+ Partials       33       28       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebp sebp merged commit adf382d into master Jan 12, 2025
30 checks passed
@sebp sebp deleted the sklearn-1-6 branch January 12, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants