-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for scikit-learn 1.6 #504
Conversation
The failing test |
@sebp if you require I am happy to collaborate |
@AYUSH27112021 Thanks for your kind offer. The code in the sklearn-1-6 branch already works. I still have to check if there are any new APIs that I need to account for. |
c694839
to
9abf0e1
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
BaseEstimator._validate_data has been deprecated
force_all_finite has been deprecated
Import from sklearn.utils.validation instead
They are already covered by parameter constraints
Parameter constraints prevent this branch to be executed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #504 +/- ##
==========================================
+ Coverage 98.23% 98.51% +0.28%
==========================================
Files 37 37
Lines 3564 3568 +4
Branches 472 470 -2
==========================================
+ Hits 3501 3515 +14
+ Misses 30 25 -5
+ Partials 33 28 -5 ☔ View full report in Codecov by Sentry. |
Checklist
What does this implement/fix? Explain your changes
Adds support for scikit-learn 1.6 and drops support for previous versions.