Fix v010 DistQuery::Rewards bug #1094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontract expects an empty vector
eladr7
requested review from
Cashmaney,
reuvenpo,
toml01,
assafmo and
liorbond
as code owners
|
Hi, please point the PR to the branch you came out of, rather than master |
|
Also, without the ability to upgrade contracts I'm not sure I feel comfortable fixing this (i.e. breaking the current behavior), as we might already have contracts on mainnet that act upon "null as no rewards" and after this fix will stop functioning correctly. We might want to wait for contract upgrades before we fix this, or at least reach out to all staking derivatives teams and ask whether this affects them. Would love more feedback on this. |
|
This fixes #754 |
|
Yes I tend to agree with @assafmo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a DistQuery::Rewards, where the delegator does not have any pending rewards the query returns null for rewards. e.g. {"rewards":null,"total":[]}
The desired result is to return an empty vector in such a case; e.g. {"rewards":[],"total":[]}
*I will change the fix to be more pretty in an upcoming update