Skip to content

Commit

Permalink
Merge pull request #30 from bradwarwick/main
Browse files Browse the repository at this point in the history
✨ Support Laravel 11
  • Loading branch information
coolsam726 authored Oct 2, 2024
2 parents 9682250 + 2783155 commit f3d7e67
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 38 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/phpstan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.1'
php-version: '8.3'
coverage: none

- name: Install composer dependencies
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ jobs:
strategy:
fail-fast: true
matrix:
os: [ubuntu-latest, windows-latest]
php: [8.2, 8.1]
laravel: [10.*]
stability: [prefer-lowest, prefer-stable]
os: [ubuntu-latest]
php: [8.3]
laravel: [11.*]
stability: [prefer-stable]
include:
- laravel: 10.*
testbench: 8.*
- laravel: 11.*
testbench: 9.*
carbon: ^2.63

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}
name: PHP ${{ matrix.php }}, Laravel ${{ matrix.laravel }}

steps:
- name: Checkout code
Expand Down
23 changes: 12 additions & 11 deletions composer.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"name": "coolsam/signature-pad",
"name": "bradwarwick/signature-pad",
"description": "Signature Pad for FilamentPHP",
"keywords": [
"coolsam",
"laravel",
"signature-pad"
],
"homepage": "https://github.com/coolsam/signature-pad",
"homepage": "https://github.com/bradwarwick/signature-pad",
"support": {
"issues": "https://github.com/coolsam/signature-pad/issues",
"source": "https://github.com/coolsam/signature-pad"
"issues": "https://github.com/bradwarwick/signature-pad/issues",
"source": "https://github.com/bradwarwick/signature-pad"
},
"license": "MIT",
"authors": [
Expand All @@ -20,20 +20,21 @@
}
],
"require": {
"php": "^8.1",
"php": "^8.3",
"filament/forms": "^3.0",
"illuminate/contracts": "^10.0",
"illuminate/contracts": "^11.0",
"spatie/laravel-package-tools": "^1.15.0"
},
"require-dev": {
"roave/security-advisories": "dev-latest",
"filament/filament": "^3.0",
"laravel/pint": "^1.0",
"nunomaduro/collision": "^7.9",
"nunomaduro/collision": "^8.0",
"nunomaduro/larastan": "^2.0.1",
"orchestra/testbench": "^8.0",
"pestphp/pest": "^2.0",
"pestphp/pest-plugin-arch": "^2.0",
"pestphp/pest-plugin-laravel": "^2.0",
"orchestra/testbench": "^9.0",
"pestphp/pest": "^3.0",
"pestphp/pest-plugin-arch": "^3.0",
"pestphp/pest-plugin-laravel": "^3.0",
"phpstan/extension-installer": "^1.1",
"phpstan/phpstan-deprecation-rules": "^1.0",
"phpstan/phpstan-phpunit": "^1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/Forms/Components/Fields/SignaturePad.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

class SignaturePad extends Field implements Contracts\CanBeLengthConstrained, Contracts\HasAffixActions
{
use HasSignaturePadAttributes;
use Concerns\CanBeAutocapitalized;
use Concerns\CanBeAutocompleted;
use Concerns\CanBeLengthConstrained;
Expand All @@ -20,6 +19,7 @@ class SignaturePad extends Field implements Contracts\CanBeLengthConstrained, Co
use Concerns\HasInputMode;
use Concerns\HasPlaceholder;
use HasExtraAlpineAttributes;
use HasSignaturePadAttributes;

const PACKAGE_NAME = 'coolsam/signature-pad';

Expand Down
2 changes: 1 addition & 1 deletion src/Forms/Concerns/HasSignaturePadAttributes.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ trait HasSignaturePadAttributes
protected bool $hideDownloadButtons = false;

/**
* @param bool $hide = true
* @param bool $hide = true
*/
public function hideDownloadButtons(bool $hide = true): static
{
Expand Down
4 changes: 1 addition & 3 deletions src/SignaturePad.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,4 @@

namespace Coolsam\SignaturePad;

class SignaturePad extends \Coolsam\SignaturePad\Forms\Components\Fields\SignaturePad
{
}
class SignaturePad extends \Coolsam\SignaturePad\Forms\Components\Fields\SignaturePad {}
6 changes: 2 additions & 4 deletions src/SignaturePadServiceProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,7 @@ public function configurePackage(Package $package): void
}
}

public function packageRegistered(): void
{
}
public function packageRegistered(): void {}

public function packageBooted(): void
{
Expand Down Expand Up @@ -88,7 +86,7 @@ public function packageBooted(): void
}

// Testing
Testable::mixin(new TestsSignaturePad());
Testable::mixin(new TestsSignaturePad);
}

protected function getAssetPackageName(): ?string
Expand Down
5 changes: 0 additions & 5 deletions tests/ArchTest.php

This file was deleted.

5 changes: 0 additions & 5 deletions tests/ExampleTest.php

This file was deleted.

0 comments on commit f3d7e67

Please sign in to comment.