Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StartProgram and StartService settings #90

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Add StartProgram and StartService settings #90

merged 6 commits into from
Oct 20, 2023

Conversation

Luro223
Copy link
Contributor

@Luro223 Luro223 commented Sep 26, 2022

No description provided.

This was referenced Sep 26, 2022
Closed
Closed
@isaak654 isaak654 marked this pull request as draft September 26, 2022 23:28
@Luro223 Luro223 changed the title Added StartProgram and StartService Several changes for AllPages Sep 26, 2022
@Luro223 Luro223 changed the title Several changes for AllPages Additions for AllPages Sep 26, 2022
@isaak654 isaak654 changed the title Additions for AllPages Added StartProgram and StartService Sep 27, 2022
isaak654
isaak654 requested changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@isaak654 isaak654 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StartService doesn't use any executable name in order to work, but only the service name (which may differ from the executable name).

This is also confirmed in the following dialog:
service_identifier

Go to services.msc > OK > double-click on any service -> see the Service name reference.

@Luro223
Copy link
Contributor Author

Luro223 commented Sep 27, 2022

Thanks for mentioning, I'll add StartProgram and StartService as soon as I learn the advanced "functions".

@isaak654 isaak654 mentioned this pull request Jul 25, 2023
Open
isaak654
isaak654 requested changes Jul 25, 2023
View reviewed changes
Content/StartService.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the stale Marked as stale label Sep 27, 2023
@isaak654 isaak654 added help wanted Extra attention is needed and removed stale Marked as stale labels Oct 3, 2023
@isaak654 isaak654 requested a review from DavidXanatos October 17, 2023 20:25
@sandboxie-plus sandboxie-plus deleted a comment from github-actions bot Oct 17, 2023
@isaak654 isaak654 added question Further information is requested and removed help wanted Extra attention is needed question Further information is requested labels Oct 17, 2023
@isaak654 isaak654 removed the request for review from DavidXanatos October 18, 2023 20:05
@isaak654 isaak654 force-pushed the patch-4 branch 3 times, most recently from 792721c to 1613e43 Compare October 19, 2023 00:22
@github-actions github-actions bot added the stale Marked as stale label Oct 19, 2023
@sandboxie-plus sandboxie-plus deleted a comment from github-actions bot Oct 19, 2023
@isaak654 isaak654 added enhancement New feature or request and removed stale Marked as stale labels Oct 19, 2023
@isaak654 isaak654 marked this pull request as ready for review October 19, 2023 18:21
@wilders-soccerfan
Copy link
Contributor

Looks good! Just a thought, but in StartService.md, line 3 and line 13, would replacing "service name" by "service name (identifier)" be more descriptive since that is what the Sandman UI displays?

@isaak654
Copy link
Collaborator

Looks good! Just a thought, but in StartService.md, line 3 and line 13, would replacing "service name" by "service name (identifier)" be more descriptive since that is what the Sandman UI displays?

I thought about it, but only complex sentences came to mind, so I will gladly adopt your suggestion.

@offhub
Copy link
Collaborator

offhub commented Oct 20, 2023

Looks good.

@isaak654 isaak654 changed the title Added StartProgram and StartService Add StartProgram and StartService Oct 20, 2023
@isaak654 isaak654 changed the title Add StartProgram and StartService Add StartProgram and StartService settings Oct 20, 2023
@isaak654 isaak654 merged commit 950137b into sandboxie-plus:main Oct 20, 2023
2 checks passed
@isaak654 isaak654 removed the enhancement New feature or request label Oct 20, 2023
@isaak654 isaak654 mentioned this pull request Oct 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaak654 isaak654 isaak654 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Luro223 @wilders-soccerfan @isaak654 @offhub