Fix accumulated values for backdated queries #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
force-pushed
the
fix-accumulators-for-backdated-queries
branch
2 times, most recently
from
37b9d6e to
4737791
Compare
MichaReiser
force-pushed
the
fix-accumulators-for-backdated-queries
branch
from
4737791 to
d254390
Compare
CodSpeed Performance ReportMerging #641 will not alter performanceComparing Summary
|
|
I agree, the split done in #636 would likely make this look a bit nicer in general (I undrafted that PR now, I am pretty happy with how it looks) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on Zulip
The optimization introduced in #621 doesn't account for queries that get backdated but now have accumulated values (or had accumulated values and now no more).
This PR fixes this regression but I think it needs some cleanup before it can be landed. Specifically, I think the refactor in #636 that moves the
AccumulatedInputValuesto the memo would be an improvement. I'm happy to follow up on this sometime when I've a little more time or someone else takes it over from here.