Do not allocate input singleton data for non-singleton inputs #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #631 will not alter performanceComparing Summary
|
davidbarsky
reviewed
Dec 16, 2024
src/input/singleton.rs
Outdated
| } | ||
| } | ||
| #[derive(Default)] | ||
| pub struct NoSingleton; |
There was a problem hiding this comment.
nit: maybe NotSingleton instead?
There was a problem hiding this comment.
Changed it, (apparently the concept of a Multiton exists as well, but that's not quite fitting either here)
Veykril
force-pushed
the
veykril/push-qnsrxyrxzotu
branch
2 times, most recently
from
26f9e60 to
8b19364
Compare
Veykril
force-pushed
the
veykril/push-qnsrxyrxzotu
branch
from
8b19364 to
f033948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some type shenanigans (unfortunately can't gate on the previously used const as Rust's const story just isn't there yet), to swap the singleton field with
()if it's not needed.