Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new PRB math type UD21x18 for rps #184

Closed
andreivladbrg opened this issue Jun 29, 2024 · 5 comments · Fixed by #219
Closed

Use the new PRB math type UD21x18 for rps #184

andreivladbrg opened this issue Jun 29, 2024 · 5 comments · Fixed by #219
Assignees
@andreivladbrg
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: refactor Change that neither fixes a bug nor adds a feature. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented Jun 29, 2024 •
edited
Loading

The PR for uint128 has been merged.

We should update the uint128 ratePerSecond to use UD21x18.
@andreivladbrg andreivladbrg self-assigned this Jun 29, 2024
@andreivladbrg andreivladbrg added effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: refactor Change that neither fixes a bug nor adds a feature. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect. labels Jun 29, 2024
@smol-ninja

This comment was marked as resolved.

Sign in to view
@andreivladbrg

This comment was marked as resolved.

Sign in to view
@PaulRBerg

This comment was marked as resolved.

Sign in to view
@andreivladbrg andreivladbrg mentioned this issue Aug 13, 2024
Closed
@andreivladbrg
Copy link
Member Author

I want to mention that after we address this issue, the only variable that can be used as UD21x18 will be ratePerSecond, which I believe would be a good change to make.

wdyt?

@PaulRBerg
Copy link
Member

I agree, let's use UD2x18 for ratePerSecond.

This was referenced Aug 26, 2024
Closed
Closed
@andreivladbrg andreivladbrg changed the title Use the new PRB math types Use the new PRB math type UD21x18 for rps Aug 29, 2024
@andreivladbrg andreivladbrg mentioned this issue Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: refactor Change that neither fixes a bug nor adds a feature. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use UD21x18 for rate per second sablier-labs/flow
3 participants
@smol-ninja @PaulRBerg @andreivladbrg