Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce protocol fee on sender deposit #212

Closed
2 tasks
PaulRBerg opened this issue Aug 26, 2024 · 3 comments
Closed
2 tasks

Introduce protocol fee on sender deposit #212

PaulRBerg opened this issue Aug 26, 2024 · 3 comments
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.

Comments

@PaulRBerg
Copy link
Member

As discussed in https://github.com/sablier-labs/company-discussions/discussions/67.

Note: introducing the protocol fee will introduce the front-running risk flagged by Cantina during the 1st audit: https://github.com/cantinasec/review-sablier/issues
@PaulRBerg PaulRBerg added effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise. labels Aug 26, 2024
@smol-ninja
Copy link
Member

Should setProtocolFee be implemented via Comptroller contract or directly into SablierFlow would be fine too? Any thoughts on this?

@smol-ninja smol-ninja self-assigned this Aug 26, 2024
@PaulRBerg
Copy link
Member Author

Let's put it in Flow for simplicity's sake.

@PaulRBerg
Copy link
Member Author

Closing in favor of #213 as per the latest discussion.

@smol-ninja smol-ninja removed their assignment Aug 27, 2024
@smol-ninja smol-ninja closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@smol-ninja smol-ninja mentioned this issue Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: high Large or difficult task. priority: 1 This is important. It should be dealt with shortly. type: feature New feature or request. work: complicated Sense-analyze-respond. The relationship between cause and effect requires analysis or expertise.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smol-ninja @PaulRBerg