Add security advistory for fast-float. #2107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast-float is currently unmaintained and contains undefined behavior in checking the length of the input aldanor/fast-float-rust#28. Although a patch was implemented and merged, no release was published and there has been no communication by the author in over 3 years.
In addition, there's also potential unsoundness, due to the use of many functions that are non-local safety guarantees marked as safe, assuming the necessary safety guarantees have been met by the caller. The simplest example is in AsciiStr::first, however, this is widely used through the repository:
I've created a fork that publishes the patches for the undefined behavior and also removes the general unsoundness: