-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update query.md #1901
Open
Tbkhi
wants to merge
2,284
commits into
rust-lang:master
Choose a base branch
from
Tbkhi:query.md
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update query.md #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Yuki Okushi <[email protected]>
"Getting Started" is already *very* long; this shrinks it a bit, and puts similar info closer together.
This is advanced info that most contributors won't need to know; and for experienced contributors, it means the info is at the top of the page instead of needing to scroll.
There was a lot of information duplicated between the two, and it wasn't clear which one to look. This commit changes `contributing.md` to be strictly for contribution procedures, and moves "what should I work on" sections to "Getting Started". This also consolidates the links in `about-this-guide.md` rather than spreading them between about-this-guide, getting-started, and contributing. I suggest using https://rustc-dev-guide.org/git.html#moving-large-sections-of-code to review this commit.
This is already covered in detail on Forge: https://forge.rust-lang.org/infra/toolstate.html and linked in the previous paragraph.
Co-authored-by: Yuki Okushi <[email protected]>
since this method has been renamed in rustc. Also remove a link to documentation in error-guaranteed.md because it was unused
Co-authored-by: Tshepang Mbambo <[email protected]>
These were removed in 2021. rust-lang/rust#85993
Adds formatting and changes to wording of some concepts.
CC: @spastorino |
jieyouxu
added
the
S-waiting-on-review
Status: this PR is waiting for a reviewer to verify its content
label
Oct 8, 2024
jieyouxu
added
T-compiler
Relevant to compiler team
A-query-system
Area: query system
labels
Nov 4, 2024
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new
More context can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-query-system
Area: query system
S-waiting-on-review
Status: this PR is waiting for a reviewer to verify its content
T-compiler
Relevant to compiler team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds formatting and changes to wording of some concepts.