Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query.md #1901

Open
wants to merge 2,284 commits into
base: master
Choose a base branch
from
Open

Update query.md #1901

wants to merge 2,284 commits into from

Conversation

Tbkhi
Copy link
Contributor

@Tbkhi Tbkhi commented Feb 24, 2024

Adds formatting and changes to wording of some concepts.

langston-barrett and others added 30 commits March 16, 2023 18:40
"Getting Started" is already *very* long; this shrinks it a bit, and
puts similar info closer together.
This is advanced info that most contributors won't need to know; and for
experienced contributors, it means the info is at the top of the page
instead of needing to scroll.
There was a lot of information duplicated between the two, and it wasn't
clear which one to look. This commit changes `contributing.md` to be
strictly for contribution procedures, and moves "what should I work on"
sections to "Getting Started".

This also consolidates the links in `about-this-guide.md` rather than
spreading them between about-this-guide, getting-started, and
contributing.

I suggest using https://rustc-dev-guide.org/git.html#moving-large-sections-of-code to review this commit.
This is already covered in detail on Forge: https://forge.rust-lang.org/infra/toolstate.html
and linked in the previous paragraph.
JohnTitor and others added 24 commits January 28, 2024 19:44
since this method has been renamed in rustc.

Also remove a link to  documentation in error-guaranteed.md because it was unused
Co-authored-by: Tshepang Mbambo <[email protected]>
Adds formatting and changes to wording of some concepts.
@Tbkhi
Copy link
Contributor Author

Tbkhi commented Mar 5, 2024

CC: @spastorino

@jieyouxu jieyouxu added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 8, 2024
@jieyouxu jieyouxu added T-compiler Relevant to compiler team A-query-system Area: query system labels Nov 4, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jan 5, 2025

Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new master):

git fetch origin --all
git checkout <pr-branch>
git rebase --onto origin/master origin/master-old
git push --force-with-lease

More context can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: query system S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content T-compiler Relevant to compiler team
Projects
None yet
Development

Successfully merging this pull request may close these issues.