Updated german translations #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated german strings
AnonymousWP
suggested changes
Oct 25, 2023
There was a problem hiding this comment.
Same as here: #467 (comment). Also, do not close this PR like you did previously, but you can apply my suggestions.
Comment on lines
+44
to
+45
| <string name="source_fdroid" translatable="false">F-Droid Offiziell</string> | ||
| <string name="source_izzy" translatable="false">F-Droid Izzy</string> |
There was a problem hiding this comment.
Suggested change
| <string name="source_fdroid" translatable="false">F-Droid Offiziell</string> | |
| <string name="source_izzy" translatable="false">F-Droid Izzy</string> | |
| <string name="source_fdroid" translatable="false">F-Droid (Main)</string> | |
| <string name="source_izzy" translatable="false">F-Droid (Izzy)</string> |
Again, you shouldn't modify those.
There was a problem hiding this comment.
Just look at the main strings.xml in the values folder.
Those strings were also changed and have the brackets removed.
There was a problem hiding this comment.
Yes, that's fair, but you shouldn't put "Officiziell". Keep it as-is with out the brackets.
There was a problem hiding this comment.
Maybe I should mark these as translatable.
rumboalla
reviewed
Oct 26, 2023
| <string name="source_aptoide" translatable="false">Aptoide</string> | ||
| <string name="source_github" translatable="false">GitHub</string> | ||
| <string name="source_gitlab" translatable="false">GitLab</string> | ||
| <string name="source_apkpure" translatable="false">APKPure</string> |
There was a problem hiding this comment.
There's no need to add strings that are marked as non traslatable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated german strings